Skip to content

Add Checker::threads - #1394

Merged
clauderic merged 1 commit into
mainfrom
theme-check-threads
Nov 13, 2026
Merged

clauderic merged 1 commit into
mainfrom
theme-check-threads

Conversation

@clauderic

@clauderic clauderic commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

What are you adding in this PR?

Checker::threads(n), how many threads check the files. 0, the default and what a run did before, is one per core. With 1, the files are checked on the calling thread, and no thread is spawned. agent-server runs checks on its own thread pool, so it wants to choose.

A check that panicked used to panic the run with check thread panicked. The panic is now resumed on the calling thread with its own payload.

Stacked for agent-server, to merge in order:

  1. Add Checker::ignore #1393 Checker::ignore
  2. Add Checker::threads #1394 Checker::threads (this PR)
  3. Add Checker::cancelable #1395 Checker::cancelable

Tophatting

  • one_thread_is_the_calling_thread and a_panic_is_resumed_with_its_message in lib.rs. Both fail without the runner change.
  • cargo test --workspace

Before you deploy

  • I included a patch bump changeset. theme-check-rs is 0.1.x, where an addition is a patch bump (0.1.0 → 0.1.1).
  • My feature is backward compatible

🤖 Generated with Claude Code

@clauderic
clauderic requested a review from a team as a code owner November 12, 2026 17:54
This was referenced Nov 12, 2026
@clauderic
clauderic added this pull request to stack #1396 November 12, 2026 19:27
Base automatically changed from theme-check-ignore to main November 12, 2026 21:46
agent-server checks themes inside a server that has its own thread pool, so it wants to set how
many threads a run takes. `.threads(1)` checks the files on the calling thread, and the default,
0, is one per core.

A check that panicked used to panic the runner with a generic message. The panic is now resumed
on the calling thread with its own payload.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@clauderic
clauderic merged commit 2557514 into main Nov 13, 2026
9 checks passed
@clauderic
clauderic deleted the theme-check-threads branch November 13, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants