Repository navigation
Add Checker::threads - #1394
Merged
Merged
Add Checker::threads#1394
Conversation
This was referenced Nov 12, 2026
Merged
clauderic
force-pushed
the
theme-check-threads
branch
from
November 12, 2026 21:45
6cf42de to
26bcbb7
Compare
agent-server checks themes inside a server that has its own thread pool, so it wants to set how many threads a run takes. `.threads(1)` checks the files on the calling thread, and the default, 0, is one per core. A check that panicked used to panic the runner with a generic message. The panic is now resumed on the calling thread with its own payload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
clauderic
force-pushed
the
theme-check-threads
branch
from
November 12, 2026 21:46
26bcbb7 to
d1d509d
Compare
charlespwd
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Checker::threads(n), how many threads check the files. 0, the default and what a run did before, is one per core. With 1, the files are checked on the calling thread, and no thread is spawned. agent-server runs checks on its own thread pool, so it wants to choose.A check that panicked used to panic the run with
check thread panicked. The panic is now resumed on the calling thread with its own payload.Stacked for agent-server, to merge in order:
Checker::ignoreChecker::threads(this PR)Checker::cancelableTophatting
one_thread_is_the_calling_threadanda_panic_is_resumed_with_its_messageinlib.rs. Both fail without the runner change.cargo test --workspaceBefore you deploy
changeset.theme-check-rsis 0.1.x, where an addition is a patch bump (0.1.0 → 0.1.1).🤖 Generated with Claude Code